Re: [PATCH] Support scheme0-scheme1-scheme2-scheme3 argument pattern for markup commands.

[Carl Sorensen]

On 2/22/10 10:12 AM, "Neil Puttock" <address@hidden> wrote:

> On 22 February 2010 16:39, Carl Sorensen <address@hidden> wrote:
>> Any concerns about me pushing this patch?
> 
> What's the proposed markup command which needs this?

Thomas is trying to clean up the ChordName markup definition with a standard
format that should allow representation of all of the standard chord name
systems we've been able to identify.

The thought is that there will be things like the root, the quality, the
alterations, the bass, and the stack.  Then a chord name could be defined by
passing each of these in.

I'm not sure exactly  what the current proposed syntax is (we've had some
discussions off-list, but not for a while).  I would have expected him to
add Markup 0-5, instead of SCM 0-4.  But I haven't seen the specifics of his
final proposal yet.

Thomas's approach has been to try to separate out the specifics of the new
ChordName algorithms from the infrastructure required to support them, so I
think that's why this patch came along.

> 
> LGTM, but will need documenting in Extending 2.2.3.

Yes, it will.  I'll take care of that.

Thanks,

Carl