Re: Fix #189: Episema over single neume. (issue186189)

[n . puttock]

Reviewers: hanwenn,

Message:
Hi Han-Wen,

Thanks for your review.

Cheers,
Neil


http://codereview.appspot.com/186189/diff/2001/2005
File lily/episema-engraver.cc (right):

http://codereview.appspot.com/186189/diff/2001/2005#newcode92
lily/episema-engraver.cc:92: announce_end_grob (finished_, SCM_EOL);
On 2010/02/24 23:11:50, hanwenn wrote:
> this should point to the STOP event

Done.

http://codereview.appspot.com/186189/diff/2001/2005#newcode101
lily/episema-engraver.cc:101: Episema_engraver::typeset_all ()
On 2010/02/24 23:11:50, hanwenn wrote:
> typeset_finished() ?

Done.

http://codereview.appspot.com/186189/diff/2001/2005#newcode114
lily/episema-engraver.cc:114: if (span_ && !span_->get_bound (LEFT))
On 2010/02/24 23:11:50, hanwenn wrote:
> what if note_cols is empty?

Hmm, that could be dangerous. :)

If I check for note_columns_.size (), is it worth using
currentMusicalColumn (which would allow an episema to be typeset over a
skip)?

Description:
Fix #189: Episema over single neume.

* add Episema_engraver (based on Text_spanner_engraver) which listens to
  EpisemaEvent and creates Episema spanner

* set NoteHeads as 'side-support-elements so spanner can be quantized
over
  neume/melisma

* ensure episema doesn't extend past bound items by setting NoteColumns
  as spanner bounds

* add regression test

Please review this at http://codereview.appspot.com/186189/show

Affected files:
  M Documentation/notation/ancient.itely
  M input/regression/display-lily-tests.ly
  A input/regression/episema.ly
  A lily/episema-engraver.cc
  M ly/engraver-init.ly
  M ly/gregorian.ly
  M ly/spanners-init.ly
  M scm/define-event-classes.scm
  M scm/define-grobs.scm
  M scm/define-music-display-methods.scm
  M scm/define-music-types.scm