Re: Rationalize string number handling for notes and chords (issue906045)

[Carl . D . Sorensen]

Reviewers: Neil Puttock,


http://codereview.appspot.com/906045/diff/1/3
File lily/articulations.cc (right):

http://codereview.appspot.com/906045/diff/1/3#newcode4
lily/articulations.cc:4: Copyright (C) 2010--2010  Carl Sorensen
<address@hidden>
On 2010/04/12 20:12:31, Neil Puttock wrote:
> 2010  Carl Sorensen

> (make grand-replace will fail to update otherwise)

Done, and in lily/include/articulations.hh

http://codereview.appspot.com/906045/diff/1/3#newcode39
lily/articulations.cc:39: const char* articulation_name)
On 2010/04/12 20:12:31, Neil Puttock wrote:
> char const *articulation_name

Thanks!  I wasn't sure what the preferred way of doing this was.  Done.

http://codereview.appspot.com/906045/diff/1/3#newcode86
lily/articulations.cc:86: return (articulations);
On 2010/04/12 20:12:31, Neil Puttock wrote:
> return scm_reverse (articulations);

Yep -- this was leftover cruft from a previous incarnation of this
function.  Thanks for the catch.

http://codereview.appspot.com/906045/diff/1/5
File lily/include/articulations.hh (right):

http://codereview.appspot.com/906045/diff/1/5#newcode4
lily/include/articulations.hh:4: Copyright (C) 2010--2010 Carl Sorensen
<address@hidden>
On 2010/04/12 20:12:31, Neil Puttock wrote:
> 2010 Carl Sorensen

Done.

http://codereview.appspot.com/906045/diff/1/5#newcode26
lily/include/articulations.hh:26: SCM articulation_list
(vector<Stream_event*> notes,
On 2010/04/12 20:12:31, Neil Puttock wrote:
> Stream_event *

Done.

http://codereview.appspot.com/906045/diff/1/5#newcode27
lily/include/articulations.hh:27: vector<Stream_event*> articulations,
On 2010/04/12 20:12:31, Neil Puttock wrote:
> Stream_event *

Done.

http://codereview.appspot.com/906045/diff/1/5#newcode28
lily/include/articulations.hh:28: const char* articulation_name);
On 2010/04/12 20:12:31, Neil Puttock wrote:
> char const *articulation_name

Done.

http://codereview.appspot.com/906045/diff/1/6
File lily/tab-note-heads-engraver.cc (right):

http://codereview.appspot.com/906045/diff/1/6#newcode83
lily/tab-note-heads-engraver.cc:83: SCM tab_notes =
ly_cxx_vector_to_list(note_events_);
On 2010/04/12 20:12:31, Neil Puttock wrote:
> ly_cxx_vector_to_list (note_events_);

Done.

Description:
Rationalize string number handling for notes and chords

Enable the use of both articulations and events for handling
string numbers, while still allowing only some notes to have
string numbers.

Create articulations.cc to house the common code used by both
tab-note-heads-engraver and fretboards-engraver to get string
numbers from the music stream.  This same code can be used
for string-bend articulations and events.

Create a regression test to demonstrate that the code will work
with string numbers partially specified.

Please review this at http://codereview.appspot.com/906045/show

Affected files:
  M input/regression/tablature.ly
  A lily/articulations.cc
  M lily/fretboard-engraver.cc
  A lily/include/articulations.hh
  M lily/tab-note-heads-engraver.cc