Re: [PATCH]: Fix issue 1096

[Carl Sorensen]

On 5/27/10 8:15 AM, "David Kastrup" <address@hidden> wrote:

> Carl Sorensen <address@hidden> writes:
> 
>> Benjamin Peterson prepared a patch to fix this issue.
>> 
>> It's in the lexer, and I'm not at all comfortable with the lexer.  However,
>> the patch has been demonstrated to work and to not break the regtests.
>> 
>> Please review this patch.
>> 
>> http://codereview.appspot.com/1345041
> 
> I think one should try to feed erroneous strings to the includable lexer
> and look at the resulting error messages.  That's probably hard to do
> with a regtest (since the regtest is not supposed to produce errors),
> but it would provide some sanity check with regard to the error
> mechanisms tracking the right input.

Would you be willing to do so?

Thanks,

Carl