Re: Fix 1112. (issue1670042)

[joeneeman]

Reviewers: Neil Puttock,

Message:
Thanks, fixed. I'll push after "make check" finishes...


http://codereview.appspot.com/1670042/diff/1/3
File lily/constrained-breaking.cc (right):

http://codereview.appspot.com/1670042/diff/1/3#newcode384
lily/constrained-breaking.cc:384: Line_details for anything.  That's
because the approximations
On 2010/06/20 20:12:52, Neil Puttock wrote:
> Is this still true?  It appears to be used in several places.

We read it in several places, but we never set it to anything other than
zero. So it's ready to be used as soon as we decide to set it to
something better than zero, but I don't know what that is yet...

http://codereview.appspot.com/1670042/diff/1/3#newcode406
lily/constrained-breaking.cc:406: SCM page_breaking_spacing_spec =
l->c_variable ("page-breaking-between-system-spacing");
On 2010/06/20 20:12:52, Neil Puttock wrote:
> Is this here for future use or is it left over from your original
spacing patch?

It's read in lines 413 and 425 (but I see that it isn't documented
correctly in the NR...)

Description:
Fix 1112.
Add support for minimum-distance into the page-breaker.

Please review this at http://codereview.appspot.com/1670042/show

Affected files:
  A input/regression/page-breaking-min-distance.ly
  M lily/constrained-breaking.cc
  M lily/include/constrained-breaking.hh
  M lily/page-breaking.cc
  M lily/page-spacing.cc