|
| From: | n . puttock |
| Subject: | Re: Fix 1063: Nested property revert (issue1327043) |
| Date: | Sun, 04 Jul 2010 21:40:09 +0000 |
LGTM.
http://codereview.appspot.com/1327043/diff/8001/9001
File input/regression/nested-property-revert.ly (right):
http://codereview.appspot.com/1327043/diff/8001/9001#newcode1
input/regression/nested-property-revert.ly:1: \version "2.13.19"
2.13.27
http://codereview.appspot.com/1327043/diff/8001/9002
File lily/nested-property.cc (right):
http://codereview.appspot.com/1327043/diff/8001/9002#newcode64
lily/nested-property.cc:64: int copy_found = 0;
copy_found suggests a boolean; copy_count would reflect its usage better
http://codereview.appspot.com/1327043/diff/8001/9002#newcode113
lily/nested-property.cc:113: if (!drop) {
if (!drop)
{
http://codereview.appspot.com/1327043/show
| [Prev in Thread] | Current Thread | [Next in Thread] |