lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Align metronome mark at time signature or first musical element. Fix


From: jan . nieuwenhuizen
Subject: Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)
Date: Tue, 24 Aug 2010 13:26:14 +0000

 From whom?

Obviously, I missed your last set of comments.

I removed metronome-mark from the break-aligned lists and
removed the break-aligned-interface.

The self-alignment-interface was already added in a previous
version of the patch, I think.

OK, so it's unlikely, but a user might use a callback to set
'break-align-symbols instead of a simple list.

lily/metronome-engraver.cc:88: text_->get_property_data
("break-align-symbols"))
get_property ()

Ah, I see.  All changed.

I'm curious about other get_property_data () usages
though, in beam, bar-number-engraver, etc?

I also added list_p checks.

+ (non-musical . #t)

Added.



http://codereview.appspot.com/1579041/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]