Re: Adds ly:define-event-class (issue1867050)

[mtsolo]

Reviewers: Neil Puttock,


http://codereview.appspot.com/1867050/diff/17001/18001
File input/regression/scheme-text-spanner.ly (right):

http://codereview.appspot.com/1867050/diff/17001/18001#newcode5
input/regression/scheme-text-spanner.ly:5: texidoc = "uses
define-event-class to create a fully functional
On 2010/08/28 19:56:11, Neil Puttock wrote:
> A more generic docstring would be better, since you're exercising
several
> functions useful for implementing spanner engravers.

Done.

http://codereview.appspot.com/1867050/diff/17001/18001#newcode61
input/regression/scheme-text-spanner.ly:61: (side-axis . ,Y)
On 2010/08/28 19:56:11, Neil Puttock wrote:
> remove this to check `set-axis!' works

Done.

http://codereview.appspot.com/1867050/diff/17001/18001#newcode65
input/regression/scheme-text-spanner.ly:65: (Y-offset .
,ly:side-position-interface::y-aligned-side)
On 2010/08/28 19:56:11, Neil Puttock wrote:
> remove (same as side-axis)

Done.

http://codereview.appspot.com/1867050/diff/17001/18001#newcode111
input/regression/scheme-text-spanner.ly:111: (ly:grob-set-property!
On 2010/08/28 19:56:11, Neil Puttock wrote:
> (begin
>    (ly:grob-set-property! grob 'side-axis axis)
>    (ly:grob-chain-callback ...

Done.

http://codereview.appspot.com/1867050/diff/17001/18001#newcode201
input/regression/scheme-text-spanner.ly:201: a b c \schemeTextSpannerEnd
d |
On 2010/08/28 20:18:58, Neil Puttock wrote:
> + another spanner to check ly:engraver-announce-end-grob works, e.g.,

> \override SchemeTextSpanner #'to-barline = ##t
> a4\schemeTextSpannerStart b d c |
> a1\schemeTextSpannerEnd |

Done.

Description:
Adds ly:define-event-class



Create ly:define-event-class

Please review this at http://codereview.appspot.com/1867050/

Affected files:
  A input/regression/scheme-text-spanner.ly
  scm/define-event-classes.scm