lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Clef support for cue notes (issue2726043)


From: tdanielsmusic
Subject: Re: Clef support for cue notes (issue2726043)
Date: Mon, 01 Nov 2010 17:22:12 +0000

Code not checked; and I still don't understand Scheme indentation, but
at least it ought to be consistent.

Trevor



http://codereview.appspot.com/2726043/diff/1/input/regression/cue-clef.ly
File input/regression/cue-clef.ly (right):

http://codereview.appspot.com/2726043/diff/1/input/regression/cue-clef.ly#newcode4
input/regression/cue-clef.ly:4: texidoc = "Clefs for cue notes: Normal
clefs should be printed, and in addition
On 2010/10/31 19:32:50, Valentin Villenave wrote:
Is it "Normal" that this word is capitalized?
Not normally, but in this case it is correct, even in English English.
The part before the colon is a heading, and the actual sentence begins
after the colon, so has a capitalised first word.

http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc
File lily/cue-clef-engraver.cc (right):

http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode108
lily/cue-clef-engraver.cc:108: if (!clef_)
Indentation?

http://codereview.appspot.com/2726043/diff/1/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/2726043/diff/1/scm/define-context-properties.scm#newcode250
scm/define-context-properties.scm:250: (forceCueClef ,boolean? "Show cue
 clef symbol, even if it has not
spacing

http://codereview.appspot.com/2726043/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/2726043/diff/1/scm/define-grobs.scm#newcode572
scm/define-grobs.scm:572: (break-align-anchor .
,ly:break-aligned-interface::calc-extent-aligned-anchor)
Indentation

http://codereview.appspot.com/2726043/diff/1/scm/define-grobs.scm#newcode594
scm/define-grobs.scm:594: (break-align-anchor .
,ly:break-aligned-interface::calc-extent-aligned-anchor)
Indentation

http://codereview.appspot.com/2726043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]