[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergro
From: |
Carl Sorensen |
Subject: |
Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup |
Date: |
Sun, 7 Nov 2010 06:58:18 -0700 |
On 11/7/10 7:07 AM, "Graham Percival" <address@hidden> wrote:
> On Sun, Nov 07, 2010 at 12:50:20PM +0000, Graham Percival wrote:
>> The normal method would be for convert-ly to print a warning
>> message to the console. Why is this Dynamics thing so different
>> from previous changes?
>
> Another option is to argue that in-file comments are much more
> noticeable than console warning messages, and thus _any_ change
> which we current display a NOT_SMART rule on the console should
> instead be placed inside the file as a comment.
While I can see some justification for this, I don't think I'd be in favor
of it in general.
If we could collect all the NOT_SMART output and put it as comments at the
top of the file, I'd be OK with that. But I don't like having them
scattered throughout the file.
I could be convinced otherwise, though.....
Thanks,
Carl
- [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performer group, Valentin Villenave, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Trevor Daniels, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Graham Percival, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Trevor Daniels, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Reinhold Kainhofer, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamicsperformergroup, Trevor Daniels, 2010/11/08
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamicsperformergroup, Valentin Villenave, 2010/11/08
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamicsperformergroup, Trevor Daniels, 2010/11/08
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Carl Sorensen, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Trevor Daniels, 2010/11/07