Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

[ianhulin44]

Another thought re the conditional (define-module) idea, if it's (if)
making the guile compilation barf, we could try using (cond) or
(cond-expand) instead.

Ian


http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):

http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode41
scm/display-lily.scm:41: (use-modules (ice-9 curried-definitions)))
On 2010/11/02 21:53:54, Patrick McCarty wrote:
> This doesn't work for me with Guile 1.9.13.

> I see this in the log as the Scheme files are compiling:

> ;;; compiling
/home/pnorcks/usr/share/lilypond/2.13.39/scm/music-functions.scm
> ;;; compiling
/home/pnorcks/usr/share/lilypond/2.13.39/scm/display-lily.scm
> ;;; WARNING: compilation of
> /home/pnorcks/usr/share/lilypond/2.13.39/scm/display-lily.scm failed:
> ;;; key syntax-error, throw args (macroexpand "~a in ~a" ("source
expression
> failed to match any pattern" (define ((make-music-type-predicate-aux
mtypes)
> expr) (if (null? mtypes) #f (or (eqv? (car mtypes) (ly:music-property
expr
> (quote name))) ((make-music-type-predicate-aux (cdr mtypes)) expr)))))
#f)
> ;;; WARNING: compilation of
> /home/pnorcks/usr/share/lilypond/2.13.39/scm/music-functions.scm
failed:
> ;;; key wrong-type-arg, throw args (#f "Wrong type to apply: ~S" (#f)
(#f))

Hmm... can you patch out the (if string>? .... block and implement the
TODO, as I had this working for Guile 1,9.12.
If this works we can do
(if (string<= (version)  "1.9.10")
(  *** current (define-module statement ***)
(  *** (define-module with additional #use-module (ice-9
curried-definitions) )
I know it's vile, but I think it will work.  I'll also try it at home
later when I have access to both guile 1.8.7 and 1.9.13.

http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode308
scm/display-lily.scm:308:
On 2010/11/02 21:53:54, Patrick McCarty wrote:
> Remove the last line of this file, since it just has trailing
whitespace.

Will do

http://codereview.appspot.com/2219044/