Re: fine-tuning new flags - feedback needed

[Janek Warchoł]

2011/2/6 Carl Sorensen <address@hidden>:
>
>> What shall i do now? I can copy modified files, delete whole
>> lilypond-git directory, download source again and make changes again,
>> but is there some better way?
>> Why is it not working? Is it because i didn't do it before making
>> changes in source files?
>
> Yes.  That's exactly the problem.  You solve it just by making a commit,
> then do the Update Source.
>
> Because stem.cc and define-grobs.cc have uncommitted changes, if you
> overwrite them you will lose the changes.  So it won't update unless you
> commit first (or you can deliberately thrown them away with the Abort
> Changes -- Reset to Origin button).

Ok. Thanks for explanation, i'll remember it.
As for now, i've already reset my git repository (that is i clicked
"Abort changes - reset to origin" in lily-git) and made the changes
again. So now i call

  git status (everything looks fine, 3 files i've changed are listed)
  git diff HEAD (i see something resembling patch file)
  git commit -a (it asked me for message - i'm not sure if it's needed
since it will be an update of existing commit, but i wrote something
there and answered yes to questions that shown up...)
  git pull -r (it said that "Current branch master is up to date.")
  git cl issue 4134041 (that's number of my first patch sent to Rietveld)
  git cl upload origin/master (and wrote some description)

and i see the changes now in http://codereview.appspot.com/4134041,
but i don't see any notification e-mail send to-devel...
Is everything right?

Thanks for help!
Janek