Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

[n . puttock]

Hi Mike,

Just a few minor nitpicks for you.

Cheers,
Neil


http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc
File lily/balloon.cc (right):

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38
lily/balloon.cc:38: static SCM internal_balloon_print (Grob *me, Grob
*p, Offset &off);
Offset *off (makes code fussy due to dereferencing)

or

Offset off (better: all existing code appears to pass Offset by value)

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode75
lily/balloon.cc:75: spanner_placement = 1.0;
 Real spanner_placement =
   min (1.0, max (robust_scm2double (me->get_property
("spanner-placement"), -1.0), -1.0));

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode93
lily/balloon.cc:93: Drul_array<Item *> bounds;
remove

http://codereview.appspot.com/4254055/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grob-properties.scm#newcode51
scm/define-grob-properties.scm:51: (annotation-balloon ,boolean? "Print
the ballon around an annotation.")
Print the balloon

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (left):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#oldcode872
scm/define-grobs.scm:872: (Y-extent . 0.0)
Y-extent . #f

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#oldcode887
scm/define-grobs.scm:887: (Y-extent . 0.0)
Y-extent . #f

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode180
scm/define-grobs.scm:180: (annotation-balloon . #f)
remove

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode181
scm/define-grobs.scm:181: (annotation-line . #f)
remove

http://codereview.appspot.com/4254055/