lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix segfault from orphaned-lines code (issue4253061)


From: n . puttock
Subject: Re: Fix segfault from orphaned-lines code (issue4253061)
Date: Mon, 07 Mar 2011 22:21:22 +0000

Hi Keith,

LGTM.

Can you put a \book { } block around all the \markuplines so we can see
the page numbers?

Cheers,
Neil


http://codereview.appspot.com/4253061/diff/2001/input/regression/markup-lines.ly
File input/regression/markup-lines.ly (right):

http://codereview.appspot.com/4253061/diff/2001/input/regression/markup-lines.ly#newcode34
input/regression/markup-lines.ly:34: } \markuplines \override-lines
#'(baseline-skip . 3.9) {
newline for each \markuplines

http://codereview.appspot.com/4253061/diff/2001/lily/paper-book.cc
File lily/paper-book.cc (right):

http://codereview.appspot.com/4253061/diff/2001/lily/paper-book.cc#newcode521
lily/paper-book.cc:521: for (SCM list = texts ; scm_is_pair (list) ;
list = scm_cdr (list))
(SCM list = texts; scm_is_pair (list); list = scm_cdr (list))

http://codereview.appspot.com/4253061/diff/2001/lily/paper-book.cc#newcode558
lily/paper-book.cc:558: /*
fix indent (+ next two lines)

http://codereview.appspot.com/4253061/diff/2001/lily/paper-book.cc#newcode564
lily/paper-book.cc:564: first->set_property ("first-markup-line",
SCM_BOOL_T);
fix indent (+ next line)

http://codereview.appspot.com/4253061/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]