Re: Potential fix for issue 1504. (issue4237057)

[mtsolo]

New patch set uploaded.  Thanks for the comments, Han-Wen!


http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode176
lily/beam.cc:176: Beam::calc_feather_widths (SCM smob)
On 2011/03/15 13:03:36, hanwenn wrote:
> actually, you could just call this length-fraction; what's calculated
over here
> is something generic to spanners.  You could even move it there.

Done.

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode204
lily/beam.cc:204: SCM temp = scm_cons (scm_from_double
(feather_fractions[i][LEFT] / total_width), scm_from_double
(feather_fractions[i][RIGHT] / total_width));
On 2011/03/15 13:04:39, hanwenn wrote:
> do you mean interval2scm(feather_factions[i] / total_width) ?

Done, but for some reason, the division operator does not work, so I had
to separate it out into LEFT and RIGHT.

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode204
lily/beam.cc:204: SCM temp = scm_cons (scm_from_double
(feather_fractions[i][LEFT] / total_width), scm_from_double
(feather_fractions[i][RIGHT] / total_width));
On 2011/03/15 13:03:36, hanwenn wrote:
> can you use a meaningful name?

> Even a 1 letter name than 'temp'

Done.

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode672
lily/beam.cc:672: to the total length.
On 2011/03/15 13:03:36, hanwenn wrote:
> ?

> should the total feathering dy be proportional to that?

Yes (I think...).

http://codereview.appspot.com/4237057/