lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Allows for degree of feathering to be tweaked (issue4289052)


From: hanwenn
Subject: Re: Allows for degree of feathering to be tweaked (issue4289052)
Date: Thu, 17 Mar 2011 12:22:57 +0000


http://codereview.appspot.com/4289052/diff/2001/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/4289052/diff/2001/lily/beam.cc#newcode1508
lily/beam.cc:1508: Interval feather_interval = robust_scm2interval
(me->get_property ("feather-direction"), Interval (0.0, 0.0));
rename the property to something saying interval.

http://codereview.appspot.com/4289052/diff/2001/lily/beam.cc#newcode1510
lily/beam.cc:1510: int feather_dir = feather_dif == 0.0 ? 0 : int
(feather_dif / fabs (feather_dif));
sign() ?

http://codereview.appspot.com/4289052/diff/2001/lily/beam.cc#newcode1518
lily/beam.cc:1518: xl, xr, Direction (feather_dir),
this still supposes that there is just one fixed amount of featheriness?

http://codereview.appspot.com/4289052/diff/2001/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/4289052/diff/2001/scm/output-lib.scm#newcode69
scm/output-lib.scm:69: (cdr feather-dir))))
why?  you're now changing the function of the 'endpoint properties to be
different than its definition.

If you need another pair to hold an intermediate value,you can create
another property.

for easier readability, consider keeping this in C++.  I dont think it
will make much of a difference, and the c -> lisp -> c jumps are harder
to follow.

http://codereview.appspot.com/4289052/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]