[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Include and document the Articulate script by Peter Chubb. (issue427
From: |
percival . music . ca |
Subject: |
Re: Include and document the Articulate script by Peter Chubb. (issue4277067) |
Date: |
Tue, 05 Apr 2011 02:41:19 +0000 |
Looks basically good. Could you add this between the first and second
points in LICENSE ?
* It does not apply to ly/articulate.ly, which is only licensed
under the GPL version 3 (not any later versions).
http://codereview.appspot.com/4277067/diff/5001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4277067/diff/5001/Documentation/notation/input.itely#newcode1956
Documentation/notation/input.itely:1956: except those enabled by
@ref{The Articulate script} when it is used:
replace with
unless you use @ref{The Articulate script}:
http://codereview.appspot.com/4277067/diff/5001/Documentation/notation/input.itely#newcode2300
Documentation/notation/input.itely:2300: @subsection The Articulate
script
I don't particularly like this doc section, but that's not important.
It's good enough, so let's play with doc-writing after the code is
added.
http://codereview.appspot.com/4277067/diff/5001/ly/articulate.ly
File ly/articulate.ly (right):
http://codereview.appspot.com/4277067/diff/5001/ly/articulate.ly#newcode1
ly/articulate.ly:1: %
Could we add a
% WARNING: this file under GPLv3 only, not GPLv3+
to the top of this file? I don't want to confuse anybody who only wants
to edit GPLv3+ files. Some people care about this, so let's be clear
for them.
http://codereview.appspot.com/4277067/