lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add predefined mandolin fretboards to lilypond. (issue4384055)


From: Marc Hohl
Subject: Re: Add predefined mandolin fretboards to lilypond. (issue4384055)
Date: Mon, 11 Apr 2011 10:34:29 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8

Am 11.04.2011 06:43, schrieb address@hidden:
Reviewers: ,

Message:
Marc Hohl has prepared a patch for mandolin predefined fretboards.

The patch looks good to me.

Please review.

Thanks,

Carl



http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely#newcode1905
Documentation/notation/fretted-strings.itely:1905:
@file{scm/string-tunings-init.scm} contains predefined banjo tunings.
Thanks for the catch!

Description:
Add predefined mandolin fretboards to lilypond.

Please review this at http://codereview.appspot.com/4384055/
Oops, I just uploaded it myself and corrected the version numbers and the path for inclusion (it was \include "./predefined-..." instead of just \include "predefined-..." )

So please have a look at

http://codereview.appspot.com/4370054/

@Carl: sorry for messing all up...

Regards,

Marc

Affected files:
  A Documentation/included/display-predefined-mandolin-fretboards.ly
  M Documentation/notation/fretted-strings.itely
  M Documentation/notation/notation-appendices.itely
  A ly/predefined-mandolin-fretboards.ly



_______________________________________________
lilypond-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/lilypond-devel





reply via email to

[Prev in Thread] Current Thread [Next in Thread]