[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix issue 1605 (issue4377054)
From: |
bordage . bertrand |
Subject: |
Fix issue 1605 (issue4377054) |
Date: |
Tue, 12 Apr 2011 10:18:39 +0000 |
Reviewers: ,
Message:
This fixes issue 1605. Keith's patch takes the "\" bug into account. But
this bug also occures with simple markups, so I assume this hasn't to be
fixed.
Description:
Fix issue 1605
PDF metadata for titles now handle unclosed parentheses.
Please review this at http://codereview.appspot.com/4377054/
Affected files:
M scm/framework-ps.scm
Index: scm/framework-ps.scm
diff --git a/scm/framework-ps.scm b/scm/framework-ps.scm
index
bd4846654add4ffda7d5d482a886197c972af411..07ceef53d4d412a21305bc9a2cce09bef3aed34f
100644
--- a/scm/framework-ps.scm
+++ b/scm/framework-ps.scm
@@ -405,9 +405,17 @@
(define (metadata-lookup-output overridevar fallbackvar field)
(let* ((overrideval (ly:modules-lookup (list header) overridevar))
(fallbackval (ly:modules-lookup (list header) fallbackvar))
- (val (if overrideval overrideval fallbackval)))
+ (val (if overrideval overrideval fallbackval))
+ (replace-char (lambda (str char replacement-str) (string-join
(string-split str char) replacement-str)))
+ (val-string
+ (if val
+ (replace-char
+ (replace-char
+ (markup->string val)
+ #\( "\\(")
+ #\) "\\)"))))
(if val
- (format port "/~a (~a)\n" field (markup->string val)))))
+ (format port "/~a (~a)\n" field val-string))))
(display "[ " port)
(metadata-lookup-output 'pdfcomposer 'composer "Author")
(format port "/Creator (LilyPond ~a)\n" (lilypond-version))
- Fix issue 1605 (issue4377054),
bordage . bertrand <=
- Re: Fix issue 1605 (issue4377054), bordage . bertrand, 2011/04/12
- Re: Fix issue 1605 (issue4377054), bordage . bertrand, 2011/04/12
- Re: Fix issue 1605 (issue4377054), bordage . bertrand, 2011/04/12
- Re: Fix issue 1605 (issue4377054), Carl . D . Sorensen, 2011/04/12
- Re: Fix issue 1605 (issue4377054), bordage . bertrand, 2011/04/12
- Re: Fix issue 1605 (issue4377054), Carl . D . Sorensen, 2011/04/12
- Re: Fix issue 1605 (issue4377054), k-ohara5a5a, 2011/04/12
- Re: Fix issue 1605 (issue4377054), bordage . bertrand, 2011/04/12
- Re: Fix issue 1605 (issue4377054), percival . music . ca, 2011/04/14