[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: shortened flags: choosing appropriate flag (issue4410049)
From: |
mtsolo |
Subject: |
Re: shortened flags: choosing appropriate flag (issue4410049) |
Date: |
Thu, 09 Jun 2011 08:12:54 +0000 |
Hey Janek,
All the metafont stuff looks good! Last time we touched base, I recall
that we had talked about looking into embedding a lot of this info into
the font - did that prove to be not doable? Other than that, I have one
comment below about the C++ stuff.
Cheers,
Mike
http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode612
lily/stem.cc:612:
I remember we worked on a Scheme version of this a while back - I would
suggest that you replace this bit of code with that. It'll be easier to
maintain and debug, and it also hardcodes less values. There is also a
problem with the already computed bit - you are assuming that people
will not change fonts midway through a work.
http://codereview.appspot.com/4410049/