Re: describing regression checking more explicitely (issue4621041)

[lemniskata . bernoullego]

@Graham:
perfect! you caught exactly the subtleties which i was worrying that
might be there!


http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):

http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi#newcode191
Documentation/contributor/regressions.itexi:191: Ensure that currently
built binary is the one without your changes.
On 2011/06/14 22:01:49, Graham Percival wrote:
> On 2011/06/14 21:40:37, Janek Warchol wrote:
> > I think a beginner can overlook this step.

> Let's change that to:
> Run @code{make} with current git master without any of your changes.

Done.

http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi#newcode201
Documentation/contributor/regressions.itexi:201: in
@file{lilypond-git/build/} directory.
On 2011/06/14 22:01:49, Graham Percival wrote:
> On 2011/06/14 21:40:37, Janek Warchol wrote:
> > i remember that it wasn't obvious for me whether to run
> > make test-baseline
> > in lilypond-git/ or in lilypond-git/build/.

> ok.  Could we make this:

> Before making changes to the code, establish a baseline for the
comparison by
> going to the @file{lilypond-git/build/} directory and running:

> ?  I prefer not to have text underneath an example.

Done.

http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi#newcode220
Documentation/contributor/regressions.itexi:220:
build/out/test-results/index.html
On 2011/06/14 22:01:49, Graham Percival wrote:
> hmm.  Relative to the current directory, it's only
>    out/test-results/index.html

> since the build directory itself has a build/ subdir (Colin calls this
> "elephants all the way down"), I think this could be confusing.

> What about specifying
>    lilypond-git/build/...

> ?

Done.

http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201
Documentation/contributor/regressions.itexi:201: in
@file{lilypond-git/build/} directory.
Maybe it would be better placed at the bottom or over point 5?
Should this be an Advanced note?

http://codereview.appspot.com/4621041/