Re: ambitus: special handling of small ambits' lines (issue4609041)

[mtsolo]

Good work!  A few comments below.


http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm#newcode141
scm/define-grobs.scm:141: (woot . 1)
This seems like 1337 $p34k - I have never heard woot in any other
context.  Perhaps change to something more descriptive?

http://codereview.appspot.com/4609041/diff/12001/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/4609041/diff/12001/scm/output-lib.scm#newcode944
scm/output-lib.scm:944: (linear-gap (+ (max gap-property 0.3) -0.45
Indentation: the -0.45 should be on the next line & lined up with the
left-parenthesis of (max.

http://codereview.appspot.com/4609041/diff/12001/scm/output-lib.scm#newcode950
scm/output-lib.scm:950: (unwooted (max (min calculated-gap gap-property)
(/ gap-property 4.5)))
80 column max

http://codereview.appspot.com/4609041/diff/12001/scm/output-lib.scm#newcode951
scm/output-lib.scm:951: (gap (+ (* unwooted woot) (* gap-property (- 1
woot))))
This codes a lot of properties.  I'm fine with the code (though I'd need
to see a regtest).  Can you try using a "details" property (like for the
Beam grob) that stores all of these values?

http://codereview.appspot.com/4609041/