lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Modify chord-name-engraver to call capo-handler (issue4800051)


From: n . puttock
Subject: Re: Modify chord-name-engraver to call capo-handler (issue4800051)
Date: Tue, 02 Aug 2011 20:24:15 +0000


http://codereview.appspot.com/4800051/diff/12002/Documentation/notation/chords.itely
File Documentation/notation/chords.itely (right):

http://codereview.appspot.com/4800051/diff/12002/Documentation/notation/chords.itely#newcode516
Documentation/notation/chords.itely:516: In make-pitch, leave the first
argument at 0, the second argument is the
A bit of syntactic sugar would OK here.  Since it's now possible to pass
pitches as arguments to music functions, it would be nice to have a
\capo function which doesn't require users to wrestle with
ly:make-pitch.

http://codereview.appspot.com/4800051/diff/12002/lily/chord-name-engraver.cc
File lily/chord-name-engraver.cc (right):

http://codereview.appspot.com/4800051/diff/12002/lily/chord-name-engraver.cc#newcode127
lily/chord-name-engraver.cc:127: SCM capo_proc = ly_lily_module_constant
("capo-handler");
While this gets round the duplication in formatter functions, it hides
the actual context property which does the formatting (and you won't
find another instance of ly_lily_module_constant () used in this way).
I still think the minor duplication is preferable.

http://codereview.appspot.com/4800051/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]