lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc: Added \compoundMeter function to NR (issue4837050)


From: lemniskata . bernoullego
Subject: Re: Doc: Added \compoundMeter function to NR (issue4837050)
Date: Fri, 05 Aug 2011 11:02:38 +0000


http://codereview.appspot.com/4837050/diff/9001/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):

http://codereview.appspot.com/4837050/diff/9001/Documentation/music-glossary.tely#newcode2114
Documentation/music-glossary.tely:2114: \compoundMeter #'((3 8) (2 8) (4
8))
Nice catch!

http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1554
Documentation/notation/rhythms.itely:1554: multiplied by 2/3 -- as 2/3 *
9/8 = 3/4 -- and in the third staff, the
either -- as ... -- or (as ...) is fine imo.

http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1642
Documentation/notation/rhythms.itely:1642: single list of numbers, where
each number in the @code{#'@var{(list)}}
After some consideration i think that we should abandon explaining the
fact that \compoundMeter #'(2 2 2 8) == \compoundMeter #'((2 2 2 8)).
Typing two braces more won't hurt anyone, while explaining how it works
seems to be either confusing ("was it a list of numbers or a list of
lists?") or too long.

http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1644
Documentation/notation/rhythms.itely:1644: listed is the
@q{denominator}.
I find it a bit confusing: is each number a numerator or not?
I'd write it like that: the last number in the list is the denominator,
remaining numbers are written in numerator.
I find the description used in the regtest
(http://lilypond.org/doc/v2.15/input/regression/58/lily-ae87e9d8.ly) the
most clear and precise, but it uses mathematical terminology (fraction,
summand) which will probably cause problems for some users :(

http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1653
Documentation/notation/rhythms.itely:1653: More complex meters can be
constructed using a @q{list of lists}.
I'd write "more lists as arguments" instead of "a @q{list of lists}"

http://codereview.appspot.com/4837050/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]