[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Get rid of some compiler warnings (issue4854049)
From: |
percival . music . ca |
Subject: |
Re: Get rid of some compiler warnings (issue4854049) |
Date: |
Wed, 10 Aug 2011 05:19:42 +0000 |
http://codereview.appspot.com/4854049/diff/5001/input/regression/completion-heads-factor.ly
File input/regression/completion-heads-factor.ly (right):
http://codereview.appspot.com/4854049/diff/5001/input/regression/completion-heads-factor.ly#newcode12
input/regression/completion-heads-factor.ly:12: \paper {
#(set-paper-size "a6") }
is this part of the compiler warnings patch?
http://codereview.appspot.com/4854049/diff/5001/lily/glissando-engraver.cc
File lily/glissando-engraver.cc (right):
http://codereview.appspot.com/4854049/diff/5001/lily/glissando-engraver.cc#newcode124
lily/glissando-engraver.cc:124: if (n1 < 0 || n2 < 0 || unsigned(n1) >=
note_heads.size ())
could we also get some parentheses around the cases? If/when we add
-Wextra
we'll get warnings about those anyway.
Also, my initial preference would be to case note_heads.size() to int
rather than n1 to unsigned, but I confess that I can't think of an
actual rule as to why that is. It's just from seeing things done that
way more often than the alternative.
http://codereview.appspot.com/4854049/