lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Better pure height approximations for beamed rests. (issue4860043)


From: n . puttock
Subject: Re: Better pure height approximations for beamed rests. (issue4860043)
Date: Wed, 10 Aug 2011 16:37:37 +0000


http://codereview.appspot.com/4860043/diff/1/lily/rest.cc
File lily/rest.cc (right):

http://codereview.appspot.com/4860043/diff/1/lily/rest.cc#newcode238
lily/rest.cc:238: // Wont play nicely with weird staves where individual
line positions are set...
Don't use line_count then :)

(see Breathing_sign::offset_callback ())

http://codereview.appspot.com/4860043/diff/1/lily/rest.cc#newcode239
lily/rest.cc:239: Interval y_ext (-line_count * ss / 2.0, line_count *
ss / 2.0);
this exaggerates the extent; is that deliberate?

Edit: Reinhold beat me to it :)

rename so it's clear this is the extent of the StaffSymbol

http://codereview.appspot.com/4860043/diff/1/lily/rest.cc#newcode249
lily/rest.cc:249: || !Beam::has_interface (beam)
is this possible?

http://codereview.appspot.com/4860043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]