Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[Carl . D . Sorensen]

Thanks for tackling this.

Your tab to space conversion on lily.scm has lots of errors.  Please
either revert those changes or get them right.

markup.scm should continue to use interval-length, rather than car.

Thanks,

Carl


http://codereview.appspot.com/4849054/diff/1/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode229
scm/lily.scm:229: (ly:message
Indent is wrong here -- should align with test, not with if.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode272
scm/lily.scm:272: (ly:get-option 'trace-memory-frequency)
Indentation needs to move in one parenthesis level on this line and
next.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode294
scm/lily.scm:294: (ly:progress "[~A" file-name))
indent one more level

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode296
scm/lily.scm:296: (ly:error (_ "cannot find: ~A") x))
indent one more level

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode299
scm/lily.scm:299: (ly:progress "]\n"))))
indent one more level

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode303
scm/lily.scm:303: (vector-ref (uname) 0) char-set:letter+digit)))
needs to be indented beyond string-tokenize

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode305
scm/lily.scm:305: (member (string-downcase (cadr platform)) '("95" "98"
"me")))))
Indent one more level

http://codereview.appspot.com/4849054/diff/1/scm/markup.scm
File scm/markup.scm (right):

http://codereview.appspot.com/4849054/diff/1/scm/markup.scm#newcode74
scm/markup.scm:74: (xoff (+ space (cdr (ly:stencil-extent head X)))))
Please keep this interval-length, because it isolates the function from
the data representation.

If we need to split lily-library.scm so we can load it earlier, we
should do so.

http://codereview.appspot.com/4849054/