[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Prevents nested tuplets from colliding. (issue4808082)
From: |
n . puttock |
Subject: |
Re: Prevents nested tuplets from colliding. (issue4808082) |
Date: |
Thu, 11 Aug 2011 21:40:36 +0000 |
Hi Mike,
Have you tested this with broken tuplets? I've tried adding breaks at
random in tuplet-nest.ly and get collisions in some cases.
Cheers,
Neil
http://codereview.appspot.com/4808082/diff/2001/input/regression/tuplet-nest.ly
File input/regression/tuplet-nest.ly (right):
http://codereview.appspot.com/4808082/diff/2001/input/regression/tuplet-nest.ly#newcode15
input/regression/tuplet-nest.ly:15: \times 2/3 { c8 [c8 c8 ]}
{ c8[ c c] }
etc.
http://codereview.appspot.com/4808082/diff/2001/lily/tuplet-bracket.cc
File lily/tuplet-bracket.cc (right):
http://codereview.appspot.com/4808082/diff/2001/lily/tuplet-bracket.cc#newcode685
lily/tuplet-bracket.cc:685: If this function is over-ridden, this may
lead to bizarre results...
Would it be feasible to remove the centring from ly:tuplet-number::print
and use a callback for X-offset instead?
http://codereview.appspot.com/4808082/diff/2001/lily/tuplet-bracket.cc#newcode687
lily/tuplet-bracket.cc:687: Stencil *my_number_stencil = unsmob_stencil
(Text_interface::print (me->get_object ("tuplet-number")));
unsmob_stencil (Text_interface::print (my_number));
http://codereview.appspot.com/4808082/