[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes boolean/SCM confusions, part 1. (issue 4875054)
From: |
reinhold . kainhofer |
Subject: |
Re: Fixes boolean/SCM confusions, part 1. (issue 4875054) |
Date: |
Thu, 18 Aug 2011 13:32:17 +0000 |
LGTM.
I haven't run the regtests, though, to make sure there are no
differences.
http://codereview.appspot.com/4875054/diff/1/lily/ambitus-engraver.cc
File lily/ambitus-engraver.cc (right):
http://codereview.appspot.com/4875054/diff/1/lily/ambitus-engraver.cc#newcode177
lily/ambitus-engraver.cc:177: Rational sig_alter = !scm_is_false
(handle)
As we are calling cdr on the handle, it would probably be better to
check for a list using ly_is_list(handle)
http://codereview.appspot.com/4875054/diff/1/lily/bar-check-iterator.cc
File lily/bar-check-iterator.cc (right):
http://codereview.appspot.com/4875054/diff/1/lily/bar-check-iterator.cc#newcode52
lily/bar-check-iterator.cc:52: if (to_boolean (tr->get_property
("ignoreBarChecks")))
scm_is_true
http://codereview.appspot.com/4875054/
- Fixes boolean/SCM confusions, part 1. (issue 4875054), cecile . hauchemaille, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), bordage . bertrand, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), bordage . bertrand, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054),
reinhold . kainhofer <=
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), cecile . hauchemaille, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), reinhold . kainhofer, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), n . puttock, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), Carl . D . Sorensen, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), cecile . hauchemaille, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), dak, 2011/08/18
- Re: Fixes boolean/SCM confusions, part 1. (issue 4875054), Carl . D . Sorensen, 2011/08/18