[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Does better polynomial calculations for avoid objects. (issue 486004
From: |
joeneeman |
Subject: |
Re: Does better polynomial calculations for avoid objects. (issue 4860042) |
Date: |
Thu, 18 Aug 2011 21:36:45 +0000 |
http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc
File flower/polynomial.cc (right):
http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc#newcode65
flower/polynomial.cc:65: Polynomial::minmax (Real l, Real r, bool dir)
const
Perhaps "bool max" instead of "bool dir"?
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc
File lily/bezier.cc (right):
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode87
lily/bezier.cc:87: Axis other = Axis ((a + 1) % NO_AXES);
Use the other_axis function.
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode217
lily/bezier.cc:217: Bezier::minmax (Axis ax, Real l, Real r, Direction
d) const
What is this function supposed to do?
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode219
lily/bezier.cc:219: Axis other = Axis ((ax + 1) % NO_AXES);
other_axis
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239
lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d !=
LEFT);
If there are multiple intersections with (say) r, then Polynomial::solve
doesn't seem to return them in any useful order. So sol[RIGHT][0] is
really just an arbitrary solution, isn't it?
http://codereview.appspot.com/4860042/
- Re: Does better polynomial calculations for avoid objects. (issue 4860042),
joeneeman <=