[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Improves horizontal spacing of axis groups that SpanBar grobs traver
From: |
Joe Neeman |
Subject: |
Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046) |
Date: |
Tue, 30 Aug 2011 14:26:49 -0700 |
On Tue, Aug 30, 2011 at 8:58 AM, Mike Solomon <address@hidden> wrote:
> On Aug 30, 2011, at 5:53 PM, address@hidden wrote:
>
>> Correct me if I'm wrong, but this is my understanding: wherever there's
>> a SpanBar, you're creating SpanBarStubs between every relevant pair of
>> staves. These don't actually get printed; they're just there for the
>> pure-height (because the SpanBar height is pretty much the whole system,
>> so it doesn't tell you where the gaps are).
>>
>
> Yes.
>
>> If that's correct, I have two broad comments: it's worth commenting
>> somewhere (span-bar-stub-engraver.cc, maybe) that the purpose of
>> SpanBarStub is for pure-height only.
>
> Will do.
>
>> But more importantly, isn't SpanBar
>> now obsoleted by SpanBarStub? That is, you can just remove the SpanBar
>> altogether and print the SpanBarStubs.
>>
>
> Mmm...you're not unright, but I'd prefer to do that in another patch if
> that's OK. It'd require a lot of deleting and moving around, and I'd first
> like to make sure that these stubs are the code base and bug free for a while
> before I deprecate an entire grob (and figure out how to deal with the syntax
> changes that come with said deprecation).
Ok, then lgtm. Probably worth putting in a comment that we intend to
remove SpanBar.
Cheers,
Joe
- Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), mtsolo, 2011/08/20
- Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), mtsolo, 2011/08/21
- Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), pkx166h, 2011/08/27
- Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), hanwenn, 2011/08/27
- Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), mtsolo, 2011/08/30
- Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), joeneeman, 2011/08/30
- Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046), mtsolo, 2011/08/31