[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates pure closures (issue 4894052)
From: |
Mike Solomon |
Subject: |
Re: Creates pure closures (issue 4894052) |
Date: |
Thu, 1 Sep 2011 09:27:38 +0200 |
On Aug 31, 2011, at 10:41 PM, address@hidden wrote:
>
> http://codereview.appspot.com/4894052/diff/19001/lily/system.cc
> File lily/system.cc (right):
>
> http://codereview.appspot.com/4894052/diff/19001/lily/system.cc#newcode773
> lily/system.cc:773: || is_unpure_pure_container
> (elts[i]->get_property_data ("Y-extent"))))
> move this to pure-relevant?
>
Good call! Done.
> http://codereview.appspot.com/4894052/diff/19001/lily/unpure-pure-container.cc
> File lily/unpure-pure-container.cc (right):
>
> http://codereview.appspot.com/4894052/diff/19001/lily/unpure-pure-container.cc#newcode54
> lily/unpure-pure-container.cc:54: 2, 0, 0, (SCM unpure, SCM pure),
> I'd make the pure part optional, if you're going to have grobs where
> both parts are identical.
Done.
Cheers,
MS