|
From: | joeneeman |
Subject: | Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046) |
Date: | Fri, 02 Sep 2011 23:27:44 +0000 |
lgtm http://codereview.appspot.com/4917046/diff/18001/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/grob.cc#newcode593 lily/grob.cc:593: return get_maybe_root_vertical_alignment (g, 0); I still think this should say return g->get_system ()->get_vertical_alignment (); because there are several grobs that implement Align_interface and you want to make sure you get the right one. http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-stub-engraver.cc File lily/span-bar-stub-engraver.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-stub-engraver.cc#newcode4 lily/span-bar-stub-engraver.cc:4: Copyright (C) 1997--2011 Han-Wen Nienhuys <address@hidden> You're looking different today, Han-Wen. http://codereview.appspot.com/4917046/
[Prev in Thread] | Current Thread | [Next in Thread] |