|
From: | Phil Holmes |
Subject: | Re: Fixes missing images in big website page (issue 4963046) |
Date: | Thu, 22 Sep 2011 10:44:16 +0100 |
Cc: <address@hidden>; <address@hidden> Sent: Wednesday, September 21, 2011 5:08 AM Subject: Re: Fixes missing images in big website page (issue 4963046)
LGTM. A quick test showed no problems in make doc. I didn't get pictures in make website, but then I tried make website without the patch applied, and I still didn't get pictures... evidently I don't have my desktop set up to create the full website any more. So that's not a reason to distrust this patch. http://codereview.appspot.com/4963046/
FWIW, running make website always produces a website with no pictures. make tries to copy them but they're only created during make doc. To get the images, on a normal make build, you must run make doc before make website.
-- Phil Holmes
[Prev in Thread] | Current Thread | [Next in Thread] |