|
From: | tdanielsmusic |
Subject: | Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061) |
Date: | Sat, 01 Oct 2011 20:27:17 +0000 |
A few comments, but otherwise LGTM. If you agree the changes and it compiles please push. Trevor http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode950 Documentation/notation/changing-defaults.itely:950: contain it. This can give rise to unexpected new staves or scores. I think this might be better placed at the end of this section. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode961 Documentation/notation/changing-defaults.itely:961: @lilypond[quote] Hmm. I think we do need verbatim here too to make it clear what is being demonstrated. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode963 Documentation/notation/changing-defaults.itely:963: \new Staff { c' d' e' f' newline and indent http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode964 Documentation/notation/changing-defaults.itely:964: \chords { d1:m7 b1:min7.5- } indent http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode971 Documentation/notation/changing-defaults.itely:971: \new Staff { c' d' e' f' newline and indent http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely#newcode972 Documentation/notation/changing-defaults.itely:972: \chords { d1:m7 b1:min7.5- } indent http://codereview.appspot.com/4839061/
[Prev in Thread] | Current Thread | [Next in Thread] |