lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improves some parmesan noteheads. (issue 4639065)


From: k-ohara5a5a
Subject: Re: Improves some parmesan noteheads. (issue 4639065)
Date: Sun, 02 Oct 2011 23:00:50 +0000

Bertrand, It looks like the additional font lookups are significantly
slowing down the Windows build,
http://code.google.com/p/lilypond/issues/detail?id=1926

Mabye it is the multiple calls to find_by_name().  It seems the logic
that chooses the glyph could be simpler, and more efficient.
... or be put within
  if (style != ly_symbol2scm ("default"))


http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc
File lily/note-head.cc (right):

http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc#newcode57
lily/note-head.cc:57: Stencil out = fm->find_by_name (idx_either +
suffix);
Look first for a symmetric glyph noteheads.s2

http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc#newcode58
lily/note-head.cc:58: if (out.is_empty ())
If there is none, figure out our direction; suppose up.

http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc#newcode69
lily/note-head.cc:69: out = fm->find_by_name (idx_either + "r" +
suffix);
If there was no noteheads.s2, look for noteheads.ur2
If there was a noteheads.s2, forget it and look for noteheads.sr2

http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc#newcode77
lily/note-head.cc:77: out = fm->find_by_name (idx_either);
If there was a noteheads.sr2 or .ur2,
  and we are on the centerline,
  then look for noteheads.sr2 or .ur2 again,
otherwise look for noteheads.s2 or .u2

http://codereview.appspot.com/4639065/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]