lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patches for LilyPond issues 1503 and 1572


From: Carl Sorensen
Subject: Re: patches for LilyPond issues 1503 and 1572
Date: Mon, 31 Oct 2011 12:04:22 +0000
User-agent: Microsoft-MacOutlook/14.13.0.110805


On 10/31/11 5:58 AM, "Adam Spiers" <address@hidden> wrote:

>2011/9/10 Janek WarchoĊ‚ <address@hidden>
>> Uploaded to Rietveld: http://codereview.appspot.com/4981052/
>
>I could be wrong but it looks like Rietveld has all the patches
>squashed into a single patch set.  Does that mean that when they get
>pushed upstream to the official repo, they'll only appear as a single
>patch?  I think it would be cleaner to keep them as separate ones.

Typically we create a single patch for a single Rietveld issue, although I
suppose it is not strictly required.

We need to verify that master builds successfully following each commit,
so if you feel that there need to be multiple commits it is probably
better to create multiple Rietveld issues.

Thanks,

Carl
>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]