|
From: | n . puttock |
Subject: | Re: Implement \once as music function able to operate on complex stuff. (issue 5322065) |
Date: | Thu, 03 Nov 2011 14:21:05 +0000 |
LGTM. http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode7 input/regression/complex-once.ly:7: \layout { ragged-right = ##t } redundant http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 input/regression/complex-once.ly:11: \unHideNotes g a \once\hideNotes b c | remove extra spaces \once \hideNotes http://codereview.appspot.com/5322065/diff/3001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/5322065/diff/3001/ly/music-functions-init.ly#newcode583 ly/music-functions-init.ly:583: (_i "Set @code{once} to @code{#t} on all layout instruction events in @var{music}") add full stop/period http://codereview.appspot.com/5322065/diff/3001/ly/music-functions-init.ly#newcode589 ly/music-functions-init.ly:589: (ly:music-warning m (_ "Can't apply \\once to timed music")))) cannot (or can not, whatever we use) http://codereview.appspot.com/5322065/
[Prev in Thread] | Current Thread | [Next in Thread] |