lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm


From: dak
Subject: Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)
Date: Sat, 12 Nov 2011 17:11:47 +0000

On 2011/11/12 17:06:15, Carl wrote:
LGTM.

Thanks,

Carl

http://codereview.appspot.com/5371050/diff/1/lily/grob.cc
File lily/grob.cc (right):

http://codereview.appspot.com/5371050/diff/1/lily/grob.cc#newcode542
lily/grob.cc:542: while (c != d) {
On 2011/11/10 16:41:54, joeneeman wrote:
> { on new line

This should be fixed by running fixcc.py, right?

Oh.  I actually already fixed that in my version.  Just did not realize
that I had not uploaded it for review again.

And now I don't want to disturb the countdown...

http://codereview.appspot.com/5371050/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]