Re: Overhauls broken bound coordinate checking (issue 5602054)

[k-ohara5a5a]

LFTM


http://codereview.appspot.com/5602054/diff/6003/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

http://codereview.appspot.com/5602054/diff/6003/lily/axis-group-interface.cc#newcode114
lily/axis-group-interface.cc:114: SCM forbidden_interfaces =
me->get_property ("bound-alignment-forbidden-interfaces");
The logic is quite complicated, with the positive set
"bound-alignment-interfaces", which if unspecified includes everything,
and then negative set "bound-alignment-forbidden-interfaces".

Did you try leaving this file alone, but specifying
'bound-alignment-interfaces where needed ?

http://codereview.appspot.com/5602054/diff/6003/lily/axis-group-interface.cc#newcode127
lily/axis-group-interface.cc:127: new_elts.erase (new_elts.begin () +
i); }
Did you mean to put a break; ?
That is, if any item ever supports two 'forbidden interfaces', you don't
want to check for an interface in the item you just deleted.

http://codereview.appspot.com/5602054/diff/6003/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/5602054/diff/6003/scm/define-grobs.scm#newcode1420
scm/define-grobs.scm:1420: (bound-alignment-forbidden-interfaces .
(break-alignable-interface))
Why not, instead,
 (bound-alignment-interfaces . (break-aligned-interface))
?

http://codereview.appspot.com/5602054/