Re: make dist broken

[Phil Holmes]

----- Original Message ----- 
From: "Graham Percival" <address@hidden>
To: "Phil Holmes" <address@hidden>
Cc: <address@hidden>
Sent: Wednesday, February 15, 2012 7:20 PM
Subject: Re: make dist broken


> On Wed, Feb 15, 2012 at 07:14:53PM -0000, Phil Holmes wrote:
> > So - presumably make dist creates the tarball, and as part of it, it
> > calls make distcheck to compare the tarball with the source tree.
> > Does that sound sensible?
>
> In normal unix packages, 'make dist' createa a tarball, then 'make
> distcheck' expands the tarball, runs configure make make clean,
> then compares the result.  Something like that.
>
> Look, the "make dist broken" is just a subject line that I typed.
> I can't remember the exact message the GUB gave, but it's the
> usual one that happens whenever people add a new translation.
> Search the mailing list archives to see me complaining about it in
> the past, as well as explaining how to fix it.  And/or look for
> such messages in the git commit log.  Something like "fix make
> dist" or "build: dist fix" should probably find the right commits.
>
> - Graham

I did look, but in the end it was easier to find the problem by looking at 
what happened in make dist.  Documentation/lang/GNUmakefile has a line like:

SUBDIRS = essay learning notation texidocs usage web extending included

which lists the subdirectories.  I'm 99% certain that adding include to the 
"new" languages will fix the problem.

You want me to do this, test and push to staging then master via patchy? 
FWIW I can't _really_ check, because my system doesn't have a rule for 
distcheck, but I can check the tarball from make dist.

--
Phil Holmes