|
From: | Phil Holmes |
Subject: | Re: Various updates to reduce make doc output (issue 5727055) |
Date: | Mon, 12 Mar 2012 18:31:35 -0000 |
Cc: <address@hidden>; <address@hidden> Sent: Monday, March 12, 2012 6:18 PM Subject: Re: Various updates to reduce make doc output (issue 5727055)
--quiet shouldn't suppress warning messages, everything else looks good. Cheers, Julien http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py File scripts/midi2ly.py (right): http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py#newcode835 scripts/midi2ly.py:835: warning (_ ('found more than 5 voices on a staff, expect bad output')) --quiet shouldn't suppress warning messages. http://codereview.appspot.com/5727055/
The problem with this warning message is that, as part of build, you can't fix it - if you want to test converting midi with more than 5 voices to lilypond, you'll get a message on screen, which is not what's wanted. Given that you're only likely to run --quiet as part of doc build, and it's not a warning you want to see every time you run make doc, I think it's better to suppress this one.
-- Phil Holmes
[Prev in Thread] | Current Thread | [Next in Thread] |