[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Patchset for fixing 2604 and 2524, also contains another patch for CG (i
From: |
graham |
Subject: |
Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044) |
Date: |
Wed, 27 Jun 2012 10:11:33 +0000 |
LGTM. One tweak, then it can be pushed directly to staging.
http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi
File Documentation/contributor/administration.itexi (right):
http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi#newcode271
Documentation/contributor/administration.itexi:271: 02 0-23/2 * * *
/bin/bash -lc
/home/patchy/git/lilypond-extra/patches/lilypond-patchy-staging.py
For the website on lilypond.org, I have this in my crontab:
# website-rebuild.cron
LILYPOND_GIT=/home/graham/lilypond/lilypond-git/
LILYPOND_WEB_MEDIA_GIT=/home/graham/lilypond/lilypond-extra/
PATH=/home/graham/usr/bin/:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin
11 * * * * $HOME/lilypond/bin/update-git.sh > /dev/null 2>&1
37 * * * * $HOME/lilypond/bin/make-website.sh > /dev/null 2>&1
Do we need to do a similar thing for this crontab? Cron has a really
annoying habit of not loading your default environment. I can't
remember if Patchy relies on those environment vars for anything, but it
might be safer to add a warning about this.
(or dump a @ref{Uploading and security} to see the type of thing I mean;
lines 211 to 224 in website-work.itexi )
http://codereview.appspot.com/6354044/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044),
graham <=