[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patchset for fixing 2604 and 2524, also contains another patch for C
From: |
John Mandereau |
Subject: |
Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044) |
Date: |
Fri, 29 Jun 2012 13:56:19 +0200 |
Il giorno ven, 29/06/2012 alle 11.00 +0000, address@hidden ha
scritto:
> LGTM, I think. I'm not completely certain what I'm reviewing here.
>
> I'm content to have this (whatever it is) go through, but in the future
> could you:
> - keep you changes in a separate git branch (locally)
> - run: git cl upload origin/master
> while on that local git branch.
This is what I did, but I introduced confusion by deliberately uploading
two dstinct patches to the same rietveld issue. These two patches can
be applied independently and in any order by patch, but "git apply"
needs an application order because the two patches touch
administration.itexi and Git patches contain kind-of file checksums.
I'll take care to avoid such confusion in the future.
Cheers,
John