lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)


From: hanwenn
Subject: Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)
Date: Fri, 10 Aug 2012 16:14:55 +0000


http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc
File lily/lily-parser.cc (right):

http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160
lily/lily-parser.cc:160: // TODO: use $parser
On 2012/08/10 07:13:58, dak wrote:
On 2012/08/10 06:58:57, Trevor Daniels wrote:
> Either this comment should be removed, or the
> earlier one should be left in.  Sorry, I don't
> understand enough of this to know which.

There is not enough context to figure out what the author of the
comment was
aiming for.  That's why I took the other comment out.  Will remove
this one as
well but not submit a separate review.

If memory serves, this is about changing the name for this variable to
indicate it is internal.

I'm also not sure how badly things will break (eg. in safe mode), if
someone does

 parser = "foo"

http://codereview.appspot.com/6460064/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]