lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't wrap EventChord around rhythmic events by default. (issue 5440


From: dak
Subject: Re: Don't wrap EventChord around rhythmic events by default. (issue 5440084)
Date: Tue, 14 Aug 2012 05:33:49 +0000

On 2012/08/14 02:45:39, Keith wrote:
Needs a tweak for \endSpanners


http://codereview.appspot.com/5440084/diff/14005/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):


http://codereview.appspot.com/5440084/diff/14005/ly/music-functions-init.ly#newcode296
ly/music-functions-init.ly:296: (if (memq (ly:music-property music
'name)
'(EventChord NoteEvent))
and   RestEvent SkipEvent
{ \endSpanners r4\cresc b b b }

I lean towards removing the check altogether.  Extract-typed-music is
quite more robust here than the original code was, and the worst that
can happen is that one finishes spanners that are both started and ended
already in complex music a second time.  But that would generate a
separate error/warning anyway, and a warning much more likely to make
sense than the one we are generating here.

http://codereview.appspot.com/5440084/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]