[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
CG: All engravers should have double-quotes around them (issue 6461098)
|
From: |
graham |
|
Subject: |
CG: All engravers should have double-quotes around them (issue 6461098) |
|
Date: |
Tue, 21 Aug 2012 11:57:45 +0000 |
LGTM, but two questions:
1) why should engravers have double-quotes? Was it only working by
accident before, or are you hoping to simplify the parser by no longer
accepting the non-quoted versions?
2) the patch title says "CG:", but this doesn't touch the CG.
http://codereview.appspot.com/6461098/
- CG: All engravers should have double-quotes around them (issue 6461098),
graham <=