lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ledger-line-spanner: symmetric extents; issue 2493 (issue 6490043)


From: mtsolo
Subject: Re: Ledger-line-spanner: symmetric extents; issue 2493 (issue 6490043)
Date: Wed, 29 Aug 2012 18:23:42 +0000


http://codereview.appspot.com/6490043/diff/7001/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):

http://codereview.appspot.com/6490043/diff/7001/lily/ledger-line-spanner.cc#newcode50
lily/ledger-line-spanner.cc:50: < Paper_column::get_rank
(previous_column)))
I'm having trouble following this naming convention.  It seems that
previous_column should have a rank falling before current column, not
after.

Also, it seems like if the variables are called this, then the order
should be correct when they are passed into the function (meaning the
one supposed to come before the other comes before the other).
Otherwise a programming error should be raised.  What would be the case
where the ranks of the columns would be reversed and what would justify
that happening?

http://codereview.appspot.com/6490043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]