[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: layout.cc: do not draw empty boxes (issue 6450113)
From: |
k-ohara5a5a |
Subject: |
Re: layout.cc: do not draw empty boxes (issue 6450113) |
Date: |
Tue, 18 Sep 2012 05:24:38 +0000 |
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode642
scm/fret-diagrams.scm:642: (corner1
On 2012/09/18 04:52:05, Graham Percival wrote:
Could we get a comment stating that -- the fact that corner1 and
corner2 will be bottom-left and top-right, but not necessarily in that
order?
After 'stencil-coordinates transforms them to coordinates on the page,
they could be top-left and bottom right. I renamed them because
thinking about which corners they are is merely distraction.
;; corner1 and corner 2 are opposite corners of the thick fret
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode649
scm/fret-diagrams.scm:649: (ordered-cons (car corner1) (car corner2))
On 2012/09/17 09:59:52, dak wrote:
I was wondering whether it would not make more sense to draw the whole
thing in
one standard orientation first and then turn the result as a whole
rather than
single coordinates.
That would be a complete rewrite.
However, that might make it harder to have lettering be always
upright,
It would seem to.
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode650
scm/fret-diagrams.scm:650: (ordered-cons (cdr corner1) (cdr corner2))
;; Intervals should have limits increasing order (else they are
considered empty)
http://codereview.appspot.com/6450113/
- Re: layout.cc: do not draw empty boxes (issue 6450113), k-ohara5a5a, 2012/09/03
- Re: layout.cc: do not draw empty boxes (issue 6450113), dak, 2012/09/03
- Re: layout.cc: do not draw empty boxes (issue 6450113), k-ohara5a5a, 2012/09/03
- Re: layout.cc: do not draw empty boxes (issue 6450113), joeneeman, 2012/09/03
- Re: layout.cc: do not draw empty boxes (issue 6450113), k-ohara5a5a, 2012/09/03
- Re: layout.cc: do not draw empty boxes (issue 6450113), dak, 2012/09/17
- Re: layout.cc: do not draw empty boxes (issue 6450113), graham, 2012/09/18
- Re: layout.cc: do not draw empty boxes (issue 6450113),
k-ohara5a5a <=