lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)


From: dak
Subject: Re: Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)
Date: Wed, 26 Sep 2012 06:32:15 +0000

Reviewers: joeneeman, janek,

Message:
On 2012/09/26 05:24:37, janek wrote:
Do i understand correctly that this is something for Emacs' sake?
If so, please add this information to the commit message, so that
non-emacs
people like me will immediately know what's it about.

Oops.  Sorry for the oversight, will do.

Description:
Set up indent-tabs-mode in lexer.ll and parser.yy

indent-tabs-mode has been switched off for C++ files with
directory-local variables.

However, for lack of working better indentation modes that cooperate
well with Bison and Flex files, lexer.ll and parser.yy are using a
tab-based indentation style oriented on the Linux kernel indentation
style.  In order to not cause an even greater inconsistent mess, local
file variables are used for switching tab-based indentation back on in
those files.

Please review this at http://codereview.appspot.com/6551050/

Affected files:
  M lily/lexer.ll
  M lily/parser.yy


Index: lily/lexer.ll
diff --git a/lily/lexer.ll b/lily/lexer.ll
index 0d3f7599d899a09aab95f6800960c4e790ae6535..1caf8a5ee6f5fd8184d8ece280aaf8f5b024d04b 100644
--- a/lily/lexer.ll
+++ b/lily/lexer.ll
@@ -1,4 +1,4 @@
-%{ // -*- mode: c++; c-file-style: "linux" -*-
+%{ // -*- mode: c++; c-file-style: "linux"; indent-tabs-mode: t -*-
 /*
   This file is part of LilyPond, the GNU music typesetter.

Index: lily/parser.yy
diff --git a/lily/parser.yy b/lily/parser.yy
index 981cf40bab5a40570601b3a2b517714b5755c88d..94227e8715ee5c72ac796ee00b1d65284539fa9a 100644
--- a/lily/parser.yy
+++ b/lily/parser.yy
@@ -1,4 +1,4 @@
-/* -*- mode: c++; c-file-style: "linux" -*- */
+/* -*- mode: c++; c-file-style: "linux"; indent-tabs-mode: t -*- */
 /*
   This file is part of LilyPond, the GNU music typesetter.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]